-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walls lod200 #97
Walls lod200 #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @jamesbradleym)
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 139 at r2 (raw file):
} private class LineEqualityComparer : IEqualityComparer<Line>
lets put this in a separate file.
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 144 at r2 (raw file):
{ // Check if start and end points of lines are equal return (x.Start == y.Start && x.End == y.End) || (x.Start == y.End && x.End == y.Start);
let's use pnt1.IsAlmostEqualTo(pnt2)
here to at least give some floating point numeric tolerance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 3 unresolved discussions (waiting on @jamesbradleym)
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 117 at r2 (raw file):
Line otherLine = mergedLines[j]; if (line.IsCollinear(otherLine) && (line.TryGetOverlap(otherLine, out var overlap) || line.DistanceTo(otherLine) < 0.0001))
redundant collinearity check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 3 unresolved discussions (waiting on @wynged)
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 117 at r2 (raw file):
Previously, wynged (Eric Wassail) wrote…
redundant collinearity check?
Done.
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 139 at r2 (raw file):
Previously, wynged (Eric Wassail) wrote…
lets put this in a separate file.
Done.
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs
line 144 at r2 (raw file):
Previously, wynged (Eric Wassail) wrote…
let's use
pnt1.IsAlmostEqualTo(pnt2)
here to at least give some floating point numeric tolerance.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained, all discussions resolved
BACKGROUND:
DESCRIPTION:
This change is